[
https://issues.apache.org/jira/browse/AIRFLOW-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040185#comment-17040185
]
ASF GitHub Bot commented on AIRFLOW-6721:
-----------------------------------------
coopergillan commented on pull request #7468: [AIRFLOW-6721] Organize hive tests
URL: https://github.com/apache/airflow/pull/7468
## BEST REVIEWED COMMIT-BY-COMMIT
### Problem
Currently many different sensors and operators are tested in the Hive
operators module. Some of these operators already have test modules and others
do not. This was [originally called out by
@mik-lag](https://github.com/apache/airflow/pull/7316#issuecomment-580946162)
in #7316.
### Solution
- Move non-operator tests into separate test modules, creating new ones as
needed.
- Create a shared `TestHiveEnvironment` class from `unittest.TestCase` that
each of the test modules can use
- Preserve existing test functionality and skipping when adding tests to
existing modules
- Update test names when being added to a more general module like
`test_sql_sensor.py`
---
Issue link:
[AIRFLOW-6721](https://issues.apache.org/jira/browse/AIRFLOW-6721)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reorganize and clean up Hive tests
> ----------------------------------
>
> Key: AIRFLOW-6721
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6721
> Project: Apache Airflow
> Issue Type: Sub-task
> Components: tests
> Affects Versions: 1.10.7
> Reporter: Cooper Gillan
> Assignee: Cooper Gillan
> Priority: Major
>
> From [this PR
> comment|https://github.com/apache/airflow/pull/7316#issuecomment-580946162]:
> https://github.com/apache/airflow/blob/master/tests/providers/apache/hive/operators/test_hive.py#L29-L40
> This file contains tests for many unrelated components. I think it would be
> useful to transfer some tests to other files.
> Here is an example: PolideaInternal@a91b612
> To avoid conflicts you can do it in one PR, but it would be useful for each
> move to be in a separate commit. This will facilitate the review.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
