ashb commented on a change in pull request #7476: [AIRFLOW-6856] Bulk fetch
paused_dag_ids
URL: https://github.com/apache/airflow/pull/7476#discussion_r382476663
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -780,7 +788,12 @@ def process_file(self, file_path, zombies,
pickle_dags=False, session=None):
for dag in dagbag.dags.values():
dag.sync_to_db()
- paused_dag_ids = {dag.dag_id for dag in dagbag.dags.values() if
dag.is_paused}
+ paused_dag_ids = (
+ session.query(DagModel.dag_id)
+ .filter(DagModel.is_paused.is_(True))
+ .filter(DagModel.dag_id.in_(dagbag.dag_ids))
+ .all()
+ )
Review comment:
A few lines after this we call self._process_dags, which the makes this same
query again. Is it worth passing it in instead?
The other thing I'm wondering API wise is if this should be encapsulated
inside DagBag (something like a `dagbag.paused_dag_ids` method or accessor) -
but that may not play very well with the global/long-lived DagBag object the
webserver has.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
