msb217 commented on a change in pull request #7456: [AIRFLOW-6817] [WIP] - Move airflow __init__.py imports to sub-packages URL: https://github.com/apache/airflow/pull/7456#discussion_r382743849
########## File path: tests/jobs/test_local_task_job.py ########## @@ -24,10 +24,11 @@ import pytest from mock import patch -from airflow import AirflowException, models, settings +from airflow import settings +from airflow.exceptions import AirflowException from airflow.executors.sequential_executor import SequentialExecutor from airflow.jobs import LocalTaskJob -from airflow.models import DAG, TaskInstance as TI +from airflow.models import DAG, DagBag, TaskInstance as TI Review comment: Yes I think that would be good for consistency. Would it be worth considering a similar change to `airflow/models/__init__.py`? Removing the implicit imports of models? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
