kaxil commented on a change in pull request #7507: [AIRFLOW-6885] Delete worker
on success
URL: https://github.com/apache/airflow/pull/7507#discussion_r382946358
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -96,6 +96,8 @@ def __init__(self): # pylint: disable=too-many-statements
self.kube_labels = configuration_dict.get('kubernetes_labels', {})
self.delete_worker_pods = conf.getboolean(
self.kubernetes_section, 'delete_worker_pods')
+ self.delete_on_success = conf.getboolean(
Review comment:
```suggestion
self.delete_worker_pods_on_success = conf.getboolean(
```
I would suggest to use the explicit name as in future we can have delete
namespace etc. WDYT @dimberman ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
