ashb commented on a change in pull request #7251: [AIRFLOW-6628] Fix search
auto complete behaviour
URL: https://github.com/apache/airflow/pull/7251#discussion_r383189374
##########
File path: airflow/www/views.py
##########
@@ -2720,3 +2714,36 @@ def get_count_query(self):
.filter(models.DagModel.is_active)
.filter(~models.DagModel.is_subdag)
)
+
+ @has_access
+ @permission_name("list")
+ @provide_session
+ @expose('/autocomplete')
+ def autocomplete(self, session=None):
+ query = unquote(request.args.get('query', ''))
Review comment:
I was surprised that `request.args` didn't unquote tbh. Quoting on input is
100% the behaviour we want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services