ashb commented on a change in pull request #7492: [AIRFLOW-6871] optimize tree view for large DAGs URL: https://github.com/apache/airflow/pull/7492#discussion_r383242005
########## File path: airflow/www/views.py ########## @@ -1374,90 +1376,113 @@ def tree(self): .all() ) dag_runs = { - dr.execution_date: alchemy_to_dict(dr) for dr in dag_runs} + dr.execution_date: alchemy_to_dict(dr) for dr in dag_runs + } dates = sorted(list(dag_runs.keys())) max_date = max(dates) if dates else None min_date = min(dates) if dates else None tis = dag.get_task_instances(start_date=min_date, end_date=base_date) - task_instances = {} + task_instances: Dict[Tuple[str, datetime], Optional[models.TaskInstance]] = {} Review comment: ```suggestion task_instances: Dict[Tuple[str, datetime], models.TaskInstance] = {} ``` I think? i.e. we don't ever store None in the dict do we? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services