ashb commented on a change in pull request #7269: [AIRFLOW-6651] Add Redis
Heartbeat option
URL: https://github.com/apache/airflow/pull/7269#discussion_r383534431
##########
File path: airflow/jobs/base_job.py
##########
@@ -308,3 +316,24 @@ def query(result, items):
len(reset_tis), task_instance_str
)
return reset_tis
+
+ @provide_session
Review comment:
By using this decorators it still uses a connection.
Using `with create_session` would be better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
