kaxil commented on a change in pull request #7534: [AIRFLOW-6867] Fix bug in 
how we call kill_zombies
URL: https://github.com/apache/airflow/pull/7534#discussion_r383878207
 
 

 ##########
 File path: airflow/jobs/scheduler_job.py
 ##########
 @@ -877,7 +877,7 @@ def process_file(self, file_path, zombies, 
pickle_dags=False, session=None):
         except Exception:
             self.log.exception("Error logging import errors!")
         try:
-            self.kill_zombies(zombies)
+            self.kill_zombies(dagbag, zombies)
 
 Review comment:
   Maybe pylint would have caught it but it is currently in **pylint_todo**, so 
might have missed:
   
   
https://github.com/apache/airflow/blob/6eaa7e3b1845644d5ec65a00a997f4029bec9628/scripts/ci/pylint_todo.txt#L11

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to