kaxil commented on a change in pull request #7532: [AIRFLOW-XXXX] Fix outdated doc on settings.policy URL: https://github.com/apache/airflow/pull/7532#discussion_r383902307
########## File path: airflow/settings.py ########## @@ -79,28 +79,26 @@ json = json -def policy(task_instance): +def policy(task): Review comment: What version would you like/recommend: 1. With TYPE_CHECKING - https://github.com/apache/airflow/pull/7532/commits/fb4ede5523cb1e0aea8bff95766feffb54d5f0a5 2. Without TYPE_CHECKING - https://github.com/apache/airflow/pull/7532/commits/7776f8178d3b61cf003b10eccb7caa2be3f504a2 With (2) I am just a bit worried that there might be a chance for cyclic dependencies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
