ashb commented on a change in pull request #7523: [AIRFLOW-6843] Add 
delete_option_kwargs to delete_namespaced_pod
URL: https://github.com/apache/airflow/pull/7523#discussion_r383935377
 
 

 ##########
 File path: airflow/config_templates/config.yml
 ##########
 @@ -2035,6 +2035,17 @@
       type: string
       example: ~
       default: ""
+    - name: delete_option_kwargs
+      description: |
+        Optional keyword arguments to pass to the ``delete_namespaced_pod`` 
kubernetes client
+        ``core_v1_api`` method when using the Kubernetes Executor.
+        This should be an object and can contain any of the options listed in 
the ``v1DeleteOptions``
+        class defined here:
+        
https://github.com/kubernetes-client/python/blob/41f11a09995efcd0142e25946adc7591431bfb2f/kubernetes/client/models/v1_delete_options.py#L19
+      version_added: ~
+      type: string
+      example: "{{\"grace_period_seconds\": 10}}"
 
 Review comment:
   Doesn't affect the output, but could be done as:
   
   ```suggestion
         example: '{{"grace_period_seconds": 10}}'
   ```
   
   Also: OH GOD. Do we show this as `{` or `{{` when we render the docs. 
Becasuse it needs to be `{` -- `{{` is only needed in default_airflow.cfg 
because that is a template, but we should show in our docs is not 
templated/formated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to