ashb commented on a change in pull request #7559: [AIRFLOW-6935] Pass the SchedulerJob configuration using the constructor URL: https://github.com/apache/airflow/pull/7559#discussion_r385146211
########## File path: airflow/jobs/scheduler_job.py ########## @@ -991,10 +1057,13 @@ def is_alive(self, grace_multiplier=None): if grace_multiplier is not None: # Accept the same behaviour as superclass return super().is_alive(grace_multiplier=grace_multiplier) - scheduler_health_check_threshold = conf.getint('scheduler', 'scheduler_health_check_threshold') + # The object can be retrieved from the database, so it does not contain all the attributes. + self.scheduler_health_check_threshold = conf.getint( Review comment: None of that affects that you have created a `scheduler_health_check_threshold` kwarg to the constructor that doesn't ever do anything, but that looks like it does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services