maxirus commented on issue #6643: [AIRFLOW-6040] Fix KubernetesJobWatcher Read 
time out error
URL: https://github.com/apache/airflow/pull/6643#issuecomment-595579525
 
 
   @sbrandtb I think you should take another look at the PR and read the 
comments in this thread again. My PR doesn't change the `_request_timeout` in 
any way.
   
   > I still disagree with you setting the _request_timeout to [60, 60] by 
default
   
   Where am **I** setting this?
   
   > You just assume you are smarter than everyone else and that no one needs 
to set another timeout and just hard code it to some reasonable value (like, 10 
seconds - why not?)
   
   Nope... It's been 
[configurable](https://github.com/apache/airflow/blob/1.10.9/airflow/config_templates/default_airflow.cfg#L965)
 for a number of releases now and **I** didn't set this default value.
   
   > or you use whatever is set in Airflow's settings
   
   Yep.
   
   > or create a new setting for this
   
   Again, read the comments please. That is not how the maintainers wanted to 
handle it (see 
[here](https://github.com/apache/airflow/pull/6643#issuecomment-564987153))
   
   > ...because the first is the default in Airflow. Please, do not 
double-default.
   
   Where's the double default?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to