anitakar commented on a change in pull request #7570: [AIRFLOW-6946] Switch to MySQL 5.7 in 2.0 as base URL: https://github.com/apache/airflow/pull/7570#discussion_r389391947
########## File path: airflow/config_templates/default_airflow.cfg ########## @@ -59,6 +59,12 @@ sql_alchemy_conn = sqlite:///{AIRFLOW_HOME}/airflow.db # The encoding for the databases sql_engine_encoding = utf-8 +# Collation for `dag_id`, `task_id`, `key` columns in case they have different encoding. +# This is particularly useful in case of mysql with utf8mb4 encoding because +# primary keys for XCom table has too big size and `sql_engine_collation_for_ids` should +# be set to `utf8mb3_general_ci` +# sql_engine_collation_for_ids = Review comment: Great change and I do not want to delay it but maybe it would be worth to add some tests for collation? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services