[
https://issues.apache.org/jira/browse/AIRFLOW-6574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17055403#comment-17055403
]
ASF GitHub Bot commented on AIRFLOW-6574:
-----------------------------------------
CaptainCuddleCube commented on pull request #7671: [AIRFLOW-6574] Adding
private_environment to docker operator.
URL: https://github.com/apache/airflow/pull/7671
The docker operator currently does not have a means to pass in an
environment dict that is not exposed to the frontend.
This links to issue 6574.
---
Issue link: WILL BE INSERTED BY
[boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN =
JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [ ] Commits follow "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)"
- [ ] Relevant documentation is updated including usage instructions.
- [ ] I will engage committers as explained in [Contribution Workflow
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with
`[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Docker operator needs a private environment dict
> ------------------------------------------------
>
> Key: AIRFLOW-6574
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6574
> Project: Apache Airflow
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.10.7
> Reporter: Ashton Hudson
> Assignee: Ashton Hudson
> Priority: Major
> Labels: beginner, easyfix, newbie
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The docker operator currently assigns the environment dict to the operators
> self, which leads to the effect that when viewing the task in the browser, it
> displays all the environment variables.
> This is an issue if the docker container gets it's database credentials via
> the environment variables.
> A proposed solution is to create a private_environment dict that is added to
> the operator's class with a leading underscore. Since the browser renderer
> excludes all class attributes with a leading underscore - the information
> won't be leaked.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
