potiuk commented on a change in pull request #7688: [AIRFLOW-6794] Allow AWS
Operator RedshiftToS3Transfer To Run a Custom Query
URL: https://github.com/apache/airflow/pull/7688#discussion_r390591494
##########
File path: airflow/providers/amazon/aws/operators/redshift_to_s3.py
##########
@@ -72,10 +75,11 @@ class RedshiftToS3Transfer(BaseOperator):
@apply_defaults
def __init__( # pylint: disable=too-many-arguments
self,
- schema: str,
- table: str,
s3_bucket: str,
s3_key: str,
+ schema: str = None,
Review comment:
This is a breaking change (someone could have used those as positional
parameters) so it should be described in UPDATING.md. It's ok for 2.0 (we allow
such backwards incompatibilities) but it must be described there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
