potiuk commented on a change in pull request #7728: [AIRFLOW-5610] Add ability
to specify multiple objects to copy in GCSToGCSOperator
URL: https://github.com/apache/airflow/pull/7728#discussion_r393910336
##########
File path: tests/providers/google/cloud/operators/test_gcs_to_gcs.py
##########
@@ -28,33 +28,40 @@
TASK_ID = 'test-gcs-to-gcs-operator'
TEST_BUCKET = 'test-bucket'
-DELIMITER = '.csv'
PREFIX = 'TEST'
+SOURCE_OBJECTS_NO_FILE = ['']
+SOURCE_OBJECTS_TWO_EMPTY_STRING = ['', '']
+SOURCE_OBJECTS_SINGLE_FILE = ['test_object/file1.txt']
+SOURCE_OBJECTS_MULTIPLE_FILES = ['test_object/file1.txt',
'test_object/file2.txt']
+SOURCE_OBJECTS_LIST = ['test_object/file1.txt', 'test_object/file2.txt',
'test_object/file3.json']
+
SOURCE_OBJECT_WILDCARD_PREFIX = '*test_object'
SOURCE_OBJECT_WILDCARD_SUFFIX = 'test_object*'
SOURCE_OBJECT_WILDCARD_MIDDLE = 'test*object'
SOURCE_OBJECT_WILDCARD_FILENAME = 'test_object*.txt'
SOURCE_OBJECT_NO_WILDCARD = 'test_object.txt'
SOURCE_OBJECT_MULTIPLE_WILDCARDS = 'csv/*/test_*.csv'
DESTINATION_BUCKET = 'archive'
+DESTINATION_OBJECT = 'foo/bar'
DESTINATION_OBJECT_PREFIX = 'foo/bar'
SOURCE_FILES_LIST = [
'test_object/file1.txt',
'test_object/file2.txt',
'test_object/file3.json',
]
+DELIMITER = '.json'
Review comment:
I actually changed my mind - I see that now we have suffix/delimiter in
various places - I think it's better to keep "delimiter" from list_blob method
even if it's not an obvious name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
