potiuk commented on a change in pull request #7770: [AIRFLOW-7069] Fix CloudSQL 
system tests
URL: https://github.com/apache/airflow/pull/7770#discussion_r395297812
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/cloud_sql.py
 ##########
 @@ -324,21 +315,14 @@ def export_instance(self, instance: str, body: Dict, 
project_id: Optional[str] =
         :type project_id: str
         :return: None
         """
-        if not project_id:
-            raise ValueError("The project_id should be set")
 
 Review comment:
   It can be removed. We have the fallback_to_default_poject_id which will 
throw an error if project_id cannot be retrieved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to