potiuk commented on a change in pull request #7832: [WIP] Add production image support URL: https://github.com/apache/airflow/pull/7832#discussion_r399171768
########## File path: BREEZE.rst ########## @@ -348,18 +349,43 @@ In case of disk space errors on macOS, increase the disk space available for Doc Building the Images ------------------- -You can manually trigger building the local images using the script: +You can manually trigger building the local CI image using this command: .. code-block:: - ./breeze build-only + ./breeze build-ci-image -The scripts that build the images are optimized to minimize the time needed to rebuild the image when +And production image using this command: + +.. code-block:: + + ./breeze build-prod-image + + +The images are build with default extras - different for CI image and different for production image +and using python version chosen in breeze. You can change those parameters by specifying them as +command line options. You can see default extras used via ``./breeze flags`` or in the syntax example +below. + +For example if you want to build python 3.7 version of production image with +all extras installed you should run this command: + +.. code-block:: + + ./breeze build-prod-image --python 3.7 --extras "all" Review comment: IT will work in one combination and it is slower because it is multi-segmented image which cannot be cached directly. If you want to reflect the actual build command it should be something like ``` docker build . --build-arg PYTHON_MAJOR_MINOR_VERSION=3.7 --build-arg AIRFLOW_EXTRAS="all" --cache-from apache/airflow:master-build-3.7 --cache-from apache/airflow:master-3.7 ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
