[ 
https://issues.apache.org/jira/browse/AIRFLOW-5277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17074605#comment-17074605
 ] 

ASF GitHub Bot commented on AIRFLOW-5277:
-----------------------------------------

ashb commented on pull request #8096: [AIRFLOW-5277] Gantt chart respects 
per-user the Timezone UI setting
URL: https://github.com/apache/airflow/pull/8096
 
 
   
   
![output](https://user-images.githubusercontent.com/34150/78368532-ae30f680-75bb-11ea-88b4-ff1d76018e1c.gif)
   
   (click for a slightly larger view)
   
   `new Date()` in javascript was always returning user-local time, so we
   switch over to using MomentJS to render the ticks.
   
   I also had to fix a bug in the `redraw` function here (previously
   unused, now used when the user selects a different timezone.)
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Gannt chart shows local browser time instead of server one
> ----------------------------------------------------------
>
>                 Key: AIRFLOW-5277
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5277
>             Project: Apache Airflow
>          Issue Type: Sub-task
>          Components: webserver
>    Affects Versions: 1.10.3, 1.10.4, 1.10.5, 1.10.7
>         Environment: Ubuntu 16.04, Python 3.6, x64
>            Reporter: Dmytro Kulyk
>            Assignee: Ash Berlin-Taylor
>            Priority: Trivial
>              Labels: gantt, timezone
>         Attachments: image-2019-08-21-20-03-10-035.png
>
>
> Gannt chart shows graphs in local browser timezone (currently UTC+3) 
>  Despite of server timezone set to UTC
>  !image-2019-08-21-20-03-10-035.png|width=811,height=218!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to