kaxil commented on a change in pull request #7899: Move out get_python_source 
from www, Move get_dag to www.utils
URL: https://github.com/apache/airflow/pull/7899#discussion_r403595864
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -1797,20 +1797,6 @@ def get_paused_dag_ids(dag_ids: List[str], session: 
Session = None) -> Set[str]:
     def safe_dag_id(self):
         return self.dag_id.replace('.', '__dot__')
 
-    def get_dag(self, store_serialized_dags=False):
-        """Creates a dagbag to load and return a DAG.
-
-        Calling it from UI should set store_serialized_dags = 
STORE_SERIALIZED_DAGS.
-        There may be a delay for scheduler to write serialized DAG into 
database,
-        loads from file in this case.
-        FIXME: remove it when webserver does not access to DAG folder in 
future.
-        """
-        dag = DagBag(
 
 Review comment:
   Removing this method broke `DagModel.create_dagrun` which broke Trigger Dag 
View.
   
   PR to solve this: https://github.com/apache/airflow/pull/8148

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to