ashb commented on a change in pull request #8227: Add run_type to DagRun URL: https://github.com/apache/airflow/pull/8227#discussion_r406108915
########## File path: airflow/models/dagrun.py ########## @@ -65,14 +66,15 @@ class DagRun(Base, LoggingMixin): ) def __init__(self, dag_id=None, run_id=None, execution_date=None, start_date=None, external_trigger=None, - conf=None, state=None): + conf=None, state=None, run_type=None): self.dag_id = dag_id self.run_id = run_id self.execution_date = execution_date self.start_date = start_date self.external_trigger = external_trigger self.conf = conf self.state = state + self.run_type = run_type Review comment: Yeah, we should look at how we query dag_run table, as I'd guess we want a multi-column index on run_type + something else (exeuction date? dag id?) as we don't (I think) ever select just by run_type? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services