potiuk commented on a change in pull request #8228: Expose Airflow Webserver 
Port in Production Docker Image
URL: https://github.com/apache/airflow/pull/8228#discussion_r406370913
 
 

 ##########
 File path: scripts/ci/docker-compose/backend-mysql.yml
 ##########
 @@ -25,6 +25,8 @@ services:
       - 
AIRFLOW__CELERY__RESULT_BACKEND=db+mysql://root@mysql/airflow?charset=utf8mb4
     depends_on:
       - mysql
+    ports:
 
 Review comment:
   Currently we are using it local.yml for CI build. But it's not used in PROD 
image. I think we should have another "local-prod.yml" and expose PORT there. 
then you'd need to update `prepare_command_files()` function in `breeze` and 
modify COMPOSE_PROD_FILE to add this local-prod.yml to this variable inside 
this if:.
   ```
       if [[ "${MOUNT_LOCAL_SOURCES}" != "false" ]]; then
           COMPOSE_CI_FILE=${COMPOSE_CI_FILE}:${LOCAL_DOCKER_COMPOSE_FILE}
       fi
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to