ryanahamilton opened a new pull request #8269: [AIRFLOW-4357] Fix SVG tooltip 
positioning with custom scripting
URL: https://github.com/apache/airflow/pull/8269
 
 
   Resolves [AIRFLOW-4357](https://issues.apache.org/jira/browse/AIRFLOW-4357).
   
   Tooltip positioning was not being calculated correctly after scrolling due 
to [a known issue](https://github.com/twbs/bootstrap/issues/20280) in jQuery 
(that won't be fixed).
   
   My solution implements a custom tooltip script for proper positioning on SVG 
elements. I've replicated the markup and CSS classes of the existing Tooltips, 
so these visually look identical to the others and require no new CSS.
   
   I've tested/confirmed the fix in modern Chrome, Safari, and Firefox browsers.
   
   ![Screen Recording 2020-04-13 at 12 48 
PM](https://user-images.githubusercontent.com/3267/79139913-200bfb80-7d85-11ea-802b-c0019b45774e.gif)
   
   
   ---
   Make sure to mark the boxes below before creating PR: [x]
   
   - [x] Description above provides context of the change
   - [x] Unit tests coverage for changes (not needed for documentation changes)
   - [x] Commits follow "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)"
   - [x] Relevant documentation is updated including usage instructions.
   - [x] I will engage committers as explained in [Contribution Workflow 
Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in 
[UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request 
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)
 for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to