khyurri opened a new pull request #8274: WIP: Fix issue #8237 URL: https://github.com/apache/airflow/pull/8274 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [ ] Unit tests coverage for changes (not needed for documentation changes) - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)" - [ ] Relevant documentation is updated including usage instructions. - [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example). --- In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md). Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information. --- For fixing issue #8237 this PR 1. Removes code: ```python period_end = dag.following_schedule(next_run_date) ``` I can't find any reason for variable `period_end`. As I said in comment: this variable always has value `next_run_date + interval` and sometimes it's greater than `timezone.utcnow()`. 2. Removes code: ``` if dag.schedule_interval == '@once': period_end = next_run_date ... if next_run_date and period_end and period_end <= timezone.utcnow(): ``` Because it may be modified to: ```python if dag.schedule_interval == '@once' and next_run_date \ and next_run_date >= timezone.utcnow(): return ``` But this lines will not execute, because previous statement: ```python if not next_run_date or next_run_date > timezone.utcnow(): return ``` So if I remove this lines never changes. Please, review this PR. May be you can find a reason for existence `period_end`
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
