ashb commented on a change in pull request #8219: Add migration waiting script
and log cleaner
URL: https://github.com/apache/airflow/pull/8219#discussion_r408677245
##########
File path: airflow/cli/cli_parser.py
##########
@@ -434,6 +434,12 @@ def __init__(self, flags=None, help=None, action=None,
default=None, nargs=None,
ARG_CFG_PATH = Arg(
("--cfg-path",),
help="Path to config file to use instead of airflow.cfg")
+ARG_MIGRATION_TIMEOUT = Arg(
+ ("-t", "--migration-wait-timeout"),
+ help="timeout to wait for db to migrate ",
+ type=int,
+ default="0",
Review comment:
Given the default is 0 (i.e. don't wait) I think we should rename this
command,
Rather than `airflow db wait-for-migrations` how about `airflow db
check-migrations`, `airflow db is-fully-migrated`? Not 100% happy with either
of those so if you have any better ideas?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
