[
https://issues.apache.org/jira/browse/AIRFLOW-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17087717#comment-17087717
]
ASF GitHub Bot commented on AIRFLOW-5266:
-----------------------------------------
ashb commented on a change in pull request #6075:
URL: https://github.com/apache/airflow/pull/6075#discussion_r411377344
##########
File path: airflow/providers/amazon/aws/hooks/athena.py
##########
@@ -163,6 +213,7 @@ def poll_query_status(self, query_execution_id,
max_tries=None):
break
if max_tries and try_number >= max_tries: # Break loop if
max_tries reached
final_query_state = query_state
+ self.stop_query(query_execution_id)
Review comment:
Other than this (which I don't know if we want or not) the code looks
good, and tests are always great :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> AWS Athena Hook only returns first 1000 results
> -----------------------------------------------
>
> Key: AIRFLOW-5266
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5266
> Project: Apache Airflow
> Issue Type: Bug
> Components: aws, contrib, hooks
> Affects Versions: 1.10.4
> Reporter: Lindsay Portelli
> Assignee: Lindsay Portelli
> Priority: Minor
> Labels: easyfix, newbie, pull-request-available
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> When using the get_query_results function in the AWSAthenaHook, you will only
> get the first 1000 results for a given query execution id. See the [boto3
> documentation|https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/athena.html?highlight=start_query_execution#Athena.Client.get_query_results]
> I'll be creating a pr in the next few days.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
