mik-laj commented on a change in pull request #8429:
URL: https://github.com/apache/airflow/pull/8429#discussion_r416123217
##########
File path: airflow/providers/http/hooks/http.py
##########
@@ -66,7 +75,7 @@ def get_conn(self, headers=None):
if conn.port:
self.base_url = self.base_url + ":" + str(conn.port)
if conn.login:
- session.auth = (conn.login, conn.password)
+ session.auth = self.auth_type(conn.login, conn.password)
Review comment:
https://requests.readthedocs.io/en/master/user/authentication/
Is it used with other methods?
I think it would be better if the user passed the auth object, not just the
auth_type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
