[
https://issues.apache.org/jira/browse/AIRFLOW-6586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17101244#comment-17101244
]
ASF GitHub Bot commented on AIRFLOW-6586:
-----------------------------------------
kaxil commented on a change in pull request #7197:
URL: https://github.com/apache/airflow/pull/7197#discussion_r421137670
##########
File path: airflow/providers/google/cloud/sensors/gcs.py
##########
@@ -226,14 +228,15 @@ class GCSUploadSessionCompleteSensor(BaseSensorOperator):
template_fields = ('bucket', 'prefix')
ui_color = '#f0eee4'
+ previous_objects: Set[str]
@apply_defaults
def __init__(self,
bucket: str,
prefix: str,
inactivity_period: float = 60 * 60,
min_objects: int = 1,
- previous_num_objects: int = 0,
+ previous_objects: Optional[Set[str]] = None,
Review comment:
This is a change in the signature that should need a note in Updating.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> GCSUploadSessionCompleteSensor breaks in reschedule mode.
> ---------------------------------------------------------
>
> Key: AIRFLOW-6586
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6586
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.3
> Reporter: Jacob Ferriero
> Priority: Minor
>
> This sensor is stateful and loses state between reschedules.
> We should:
> # Warn about this in docstring
> # Add a `poke_mode_only` class decorator for sensors that aren't safe in
> reschedule mode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
