j-y-matsubara commented on a change in pull request #8757:
URL: https://github.com/apache/airflow/pull/8757#discussion_r422455491
##########
File path: docs/kubernetes.rst
##########
@@ -40,11 +40,44 @@ that has the ability to mutate pod objects before sending
them to the Kubernetes
for scheduling. It receives a single argument as a reference to pod objects,
and
is expected to alter its attributes.
-This could be used, for instance, to add sidecar or init containers
+This could be used, for instance, to add init containers
Review comment:
How is is made and used for sidecar?
We can mutation pod object by using pod_mutation_hook, but I think we can
not add any containers, excluding the init container ( in the case of using
kubernetes_request_factory.py, pod object is not V1Pod. Overwrite **part of the
contents of** req object creating in pod_request_factory.py with pod object,
and launch "Pod" by using req object. ).
In the version 2.0, We can directly edit the pod objects (V1Pod) used to
launch "Pod". Therefore, we can add any containaers (sidecar).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
