feluelle commented on a change in pull request #8877:
URL: https://github.com/apache/airflow/pull/8877#discussion_r426180163
##########
File path: tests/test_utils/amazon_system_helpers.py
##########
@@ -82,6 +89,31 @@ def delete_aws_s3_bucket(cls, name: str) -> None:
cmd = ["aws", "s3api", "delete-bucket", "--bucket", name]
cls.execute_with_ctx(cmd)
+ @classmethod
+ def create_aws_s3_key(cls, bucket_name: str, key_name: str, body:
Optional[str] = None) -> None:
+ """
+ Puts an object into the aws bucket.
+
+ :param bucket_name: name of the bucket
+ :param key_name: name of the key to add
+ :param body: optional content of the key to add
+ """
+ cmd = ["aws", "s3api", "put-object", "--bucket", bucket_name, "--key",
key_name]
Review comment:
True, but my thought is that we should not system-test our prod code
with prod code? I mean theoretically if we change our code to use a different
lib or so we also might need to change our test code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
