mik-laj commented on a change in pull request #8858:
URL: https://github.com/apache/airflow/pull/8858#discussion_r427469354



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -942,6 +968,15 @@ def __init__(self,
         self.schema_object = schema_object
 
         # BQ config
+        if not table_resource:

Review comment:
       Should we raise exception when user provide mutully exclussive 
parameters e.g. table_resource and source_uris?

##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -942,6 +968,15 @@ def __init__(self,
         self.schema_object = schema_object
 
         # BQ config
+        if not table_resource:
+            warnings.warn(
+                "Passing table parameters via key words arguments will be 
deprecated. "

Review comment:
       ```suggestion
                   "Passing table parameters via keywords arguments will be 
deprecated. "
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to