ashb commented on a change in pull request #8904:
URL: https://github.com/apache/airflow/pull/8904#discussion_r427586701



##########
File path: airflow/contrib/operators/file_to_wasb.py
##########
@@ -57,8 +57,8 @@ def execute(self, context):
         """Upload a file to Azure Blob Storage."""
         hook = WasbHook(wasb_conn_id=self.wasb_conn_id)
         self.log.info(
-            'Uploading %s to wasb://%s '
-            'as %s'.format(self.file_path, self.container_name, self.blob_name)
+            'Uploading {} to wasb://{} '
+            'as {}'.format(self.file_path, self.container_name, self.blob_name)

Review comment:
       The fix here is to do
   
   ```python
           self.log.info(
               'Uploading %s to wasb://%s as %s',
               self.file_path, self.container_name, self.blob_name)
   ```
   
   That way if the logging level is disabled, no time is wasted formatting the 
string




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to