Moress commented on a change in pull request #8911:
URL: https://github.com/apache/airflow/pull/8911#discussion_r429652975
##########
File path: airflow/sentry.py
##########
@@ -81,13 +81,17 @@ def __init__(self):
sentry_celery = CeleryIntegration()
integrations.append(sentry_celery)
- dsn = conf.get("sentry", "sentry_dsn")
+ dsn = None
+ sentry_config_opts = conf.getsection("sentry") or {}
Review comment:
> getsection method returns dict[str,str]
It's not quite true. Here
(https://github.com/apache/airflow/blob/master/airflow/configuration.py#L422)
you can see that code is going through `_section` dict and trying to cast
strings to proper type.
But fair enough it's not working for these props (list, dict and custom type
is not supported by getsection):
```
integrations
in_app_include
in_app_exclude
ignore_errors
before_breadcrumb
before_send
transport
```
I will add some guard exception for these props.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
