ashb commented on a change in pull request #9067:
URL: https://github.com/apache/airflow/pull/9067#discussion_r440092182



##########
File path: airflow/models/connection.py
##########
@@ -119,6 +120,8 @@ class Connection(Base, LoggingMixin):
     is_extra_encrypted = Column(Boolean, unique=False, default=False)
     _extra = Column('extra', String(5000))
 
+    UniqueConstraint(conn_id, name='unique_conn_id')

Review comment:
       This looks odd -- I would have expected it to be this
   ```suggestion
       __table_args = (
           UniqueConstraint(conn_id, name='unique_conn_id'),
       )
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to