mik-laj commented on a change in pull request #9273: URL: https://github.com/apache/airflow/pull/9273#discussion_r441915601
########## File path: tests/api_connexion/endpoints/test_variable_endpoint.py ########## @@ -29,38 +31,142 @@ def setUpClass(cls) -> None: def setUp(self) -> None: self.client = self.app.test_client() # type:ignore + clear_db_variables() + + def tearDown(self) -> None: + clear_db_variables() class TestDeleteVariable(TestVariableEndpoint): - @pytest.mark.skip(reason="Not implemented yet") - def test_should_response_200(self): - response = self.client.delete("/api/v1/variables/TEST_VARIABLE_KEY") + def test_should_response_204(self): + Variable.set("delete_var1", 1) + # make sure variable is added + response = self.client.get("/api/v1/variables/delete_var1") + assert response.status_code == 200 + + response = self.client.delete("/api/v1/variables/delete_var1") assert response.status_code == 204 + # make sure variable is deleted + response = self.client.get("/api/v1/variables/delete_var1") + assert response.status_code == 404 + class TestGetVariable(TestVariableEndpoint): - @pytest.mark.skip(reason="Not implemented yet") + def test_should_response_200(self): + expected_value = '{"foo": 1}' + Variable.set("TEST_VARIABLE_KEY", expected_value) response = self.client.get("/api/v1/variables/TEST_VARIABLE_KEY") assert response.status_code == 200 + assert response.json == {"key": "TEST_VARIABLE_KEY", "value": expected_value} + + def test_should_response_404_if_not_found(self): + response = self.client.get("/api/v1/variables/NONEXIST_VARIABLE_KEY") + assert response.status_code == 404 class TestGetVariables(TestVariableEndpoint): - @pytest.mark.skip(reason="Not implemented yet") - def test_should_response_200(self): + @parameterized.expand([ + ("/api/v1/variables?limit=2&offset=0", { + "variables": [ + {"key": "var1"}, + {"key": "var2"}, + ], + "total_entries": 2, + }), + ("/api/v1/variables?limit=2&offset=1", { + "variables": [ + {"key": "var2"}, + {"key": "var3"}, + ], + "total_entries": 2, + }), + ("/api/v1/variables?limit=1&offset=2", { + "variables": [ + {"key": "var3"}, + ], + "total_entries": 1, + }), + ]) + def test_should_get_list_variables(self, query, expected): + Variable.set("var1", 1) + Variable.set("var2", "foo") + Variable.set("var3", "[100, 101]") + response = self.client.get(query) + assert response.status_code == 200 + assert response.json == expected + + def test_should_honor_100_limit_default(self): + for i in range(101): + Variable.set(f"var{i}", i) response = self.client.get("/api/v1/variables") assert response.status_code == 200 + assert response.json["total_entries"] == 100 + assert len(response.json["variables"]) == 100 class TestPatchVariable(TestVariableEndpoint): - @pytest.mark.skip(reason="Not implemented yet") - def test_should_response_200(self): - response = self.client.patch("/api/v1/variables/TEST_VARIABLE_KEY") - assert response.status_code == 200 + def test_should_update_variable(self): + Variable.set("var1", "foo") + response = self.client.patch("/api/v1/variables/var1", json={ + "key": "var1", + "value": "updated", + }) + assert response.status_code == 204 + response = self.client.get("/api/v1/variables/var1") + assert response.json == { Review comment: I use green button in Intelij IDEA. <img width="316" alt="Screenshot 2020-06-18 at 03 16 39" src="https://user-images.githubusercontent.com/12058428/84966589-31211200-b112-11ea-99e1-e2bd7d57523a.png"> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org