aneesh-joseph commented on a change in pull request #9468: URL: https://github.com/apache/airflow/pull/9468#discussion_r446619667
########## File path: chart/templates/rbac/pod-launcher-rolebinding.yaml ########## @@ -21,7 +21,7 @@ {{- if and .Values.rbacEnabled .Values.allowPodLaunching }} {{- $grantScheduler := or (eq .Values.executor "LocalExecutor") (eq .Values.executor "SequentialExecutor") (eq .Values.executor "KubernetesExecutor") }} {{- $grantWorker := or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "KubernetesExecutor") }} -kind: RoleBinding +kind: ClusterRoleBinding Review comment: why do we need `ClusterRoleBinding` ? we would usually only need the Role and RoleBinding to apply to the namespace where airflow is bing installed. `ClusterRoleBinding` will create issues in managed multitenant kubernetes clusters which only provide namespace level access(and not cluster wide) Is there a test which doesn't work with `Role` and `RoleBinding` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org