mik-laj commented on pull request #9502:
URL: https://github.com/apache/airflow/pull/9502#issuecomment-650726470


   @potiuk I agree that this is not perfect and we can think of other ideas. My 
main goal is the ability to easily review changes in generated clients during 
review of changes in specifications. Being able to see differences once the 
change has been accepted will not help me.
   
   > What's the drawback of separate repositories @mik-laj ? What are you 
afraid of or want to prevent from?
   
   I am in favor of a separate repository for changes that are merged into the 
master. However, I would like to be able to easily see the impact of the change 
in specification on generated clients.  Not every change in the specification 
can be easily understood by the generated client and this should also be 
verified. It would be ideal if we had E2E tests, but it will take a while to 
develop them.
   Kubernetes has similar tests:
   https://github.com/kubernetes-client/python/tree/master/kubernetes/e2e_test
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to