turbaszek commented on a change in pull request #9472:
URL: https://github.com/apache/airflow/pull/9472#discussion_r449392019



##########
File path: tests/providers/apache/hive/hooks/test_hive.py
##########
@@ -383,6 +383,10 @@ def test_table_exists(self):
             self.hook.table_exists(str(random.randint(1, 10000)))
         )
 
+    def test_drop_partition(self):
+        self.assertTrue(self.hook.drop_partitions(self.table, db=self.database,
+                                                  part_vals=[DEFAULT_DATE_DS]))
+

Review comment:
       Do you think we can mock the client? In this way we will reduce the side 
effects and the test will not require any external service 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to