kaxil edited a comment on pull request #9647:
URL: https://github.com/apache/airflow/pull/9647#issuecomment-653642379


   > Side note
   > 
   > @kaxil @dimberman @ashb @turbaszek @mik-laj - this is an example of where 
splitting to separate repo would have been problematic.
   > 
   > This change should have been committed together with #9611 and it would 
have been rather complex to test if the `chart` and `airflow` were separate 
repos. It would not work with the scheme proposed by @kaxil where we only use 
"released" versions of helm chart for Airflow tests and the other way round 
because in this case changing the backend auth to "deny_all" had to be coupled 
with adding new configuration value in the helm chart.
   > 
   > It could work with the submodule scheme I proposed but as discussed with 
@dimberman yesterday - just coordinating this simple change across two PRs done 
in two different repos would have been a much more complex task.
   > 
   > And this is just one small change ...
   > 
   > I really think that monorepo approach and possibly split-out to separate 
repos with pushing only related changes (like @ryw commented) could be a much 
better solution.
   
   I think it should still work. In theory, the chart should allow overriding 
any runtime Airflow configs. In this case we could have used Environment 
Variable to set config. If we are not able to do we would anyway hit that 
limitation. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to