potiuk commented on a change in pull request #9371:
URL: https://github.com/apache/airflow/pull/9371#discussion_r449776113
##########
File path: chart/README.md
##########
@@ -66,7 +66,7 @@ The command removes all the Kubernetes components associated
with the chart and
## Updating DAGs
-The recommended way to update your DAGs with this chart is to build a new
docker image with the latest code (`docker build -t my-company/airflow:8a0da78
.`), push it to an accessible registry (`docker push
my-company/airflow:8a0da78`), then update the Airflow pods with that image:
+The recommended way to update your DAGs with this chart is to build a new
docker image with the latest DAG code (`docker build -t
my-company/airflow:8a0da78 .`), push it to an accessible registry (`docker push
my-company/airflow:8a0da78`), then update the Airflow pods with that image:
Review comment:
I think we will want to change that description as it is not valid any
more and we have "EMBED_DAGS" directive while building the dockerfiles + we
will add on-build most likely to add the DAGs on building deppendent image but
I will do it separately.
##########
File path: chart/README.md
##########
@@ -76,6 +76,42 @@ helm upgrade airflow . \
For local development purpose you can also build the image locally and use it
via deployment method described by Breeze.
+## Mounting DAGS using Git-Sync side car with Persistence enabled
+
+This option will use a Persistent Volume Claim with an accessMode of
`ReadWriteMany`. The scheduler pod will sync DAGs from a git repository onto
the PVC every configured number of seconds. The other pods will read the synced
DAGs. Not all volume plugins have support for `ReadWriteMany` accessMode.
Refer [Persistent Volume Access
Modes](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes)
for details
+
+```bash
+helm upgrade airflow . \
+ --set dags.persistence.enabled=true \
+ --set dags.gitSync.enabled=true
+ # you can also override the other persistence or gitSync values
+ # by setting the dags.persistence.* and dags.gitSync.* values
+ # Refer values.yaml for details
+```
+
+## Mounting DAGS using Git-Sync side car without Persistence
Review comment:
Nice to have this option.!
##########
File path: chart/tests/dags-persistent-volume-claim_test.yaml
##########
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I love the unit tests of helm chart! :heart:
##########
File path: chart/README.md
##########
@@ -159,6 +195,8 @@ The following tables lists the configurable parameters of
the Airflow chart and
| `webserver.resources.requests.cpu` | CPU Request of
webserver
| `~` |
| `webserver.resources.requests.memory` | Memory Request of
webserver
| `~` |
| `webserver.defaultUser` | Optional default
airflow user information
| `{}` |
+| `dags.persistence.*` | Dag persistence
configutation
| Refer `values.yaml` |
+| `dags.gitSync.*` | Git sync configuration
| Refer
`values.yaml` |
Review comment:
```suggestion
| `dags.gitSync.*` | Git sync configuration
| Please refer
to `values.yaml` |
```
##########
File path: chart/README.md
##########
@@ -159,6 +195,8 @@ The following tables lists the configurable parameters of
the Airflow chart and
| `webserver.resources.requests.cpu` | CPU Request of
webserver
| `~` |
| `webserver.resources.requests.memory` | Memory Request of
webserver
| `~` |
| `webserver.defaultUser` | Optional default
airflow user information
| `{}` |
+| `dags.persistence.*` | Dag persistence
configutation
| Refer `values.yaml` |
Review comment:
```suggestion
| `dags.persistence.*` | Dag persistence
configutation
| Please refer to `values.yaml` |
```
##########
File path: chart/README.md
##########
@@ -76,6 +76,42 @@ helm upgrade airflow . \
For local development purpose you can also build the image locally and use it
via deployment method described by Breeze.
+## Mounting DAGS using Git-Sync side car with Persistence enabled
+
+This option will use a Persistent Volume Claim with an accessMode of
`ReadWriteMany`. The scheduler pod will sync DAGs from a git repository onto
the PVC every configured number of seconds. The other pods will read the synced
DAGs. Not all volume plugins have support for `ReadWriteMany` accessMode.
Refer [Persistent Volume Access
Modes](https://kubernetes.io/docs/concepts/storage/persistent-volumes/#access-modes)
for details
+
+```bash
+helm upgrade airflow . \
+ --set dags.persistence.enabled=true \
+ --set dags.gitSync.enabled=true
+ # you can also override the other persistence or gitSync values
+ # by setting the dags.persistence.* and dags.gitSync.* values
+ # Refer values.yaml for details
Review comment:
```suggestion
# Please refer to values.yaml for details
```
##########
File path: chart/requirements.lock
##########
@@ -1,6 +0,0 @@
-dependencies:
Review comment:
Why do wer delete this ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
