mik-laj commented on a change in pull request #9665: URL: https://github.com/apache/airflow/pull/9665#discussion_r449920521
########## File path: tests/providers/yandex/hooks/test_yandex.py ########## @@ -0,0 +1,84 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import unittest +import mock + +from airflow.exceptions import AirflowException +from airflow.providers.yandex.hooks.yandex import YandexCloudBaseHook + + +class TestYandexHook(unittest.TestCase): + + @mock.patch('airflow.hooks.base_hook.BaseHook.get_connection') + @mock.patch('airflow.providers.yandex.hooks.yandex.YandexCloudBaseHook._get_credentials') Review comment: get_credentials method contains important logic for this class. What do you think to complete the tests for it? Now this method is simple, but in the future new authentication methods may be needed to be added. Tests will allow easy refactoring and prevent regression. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
