roy-ht opened a new issue #9827:
URL: https://github.com/apache/airflow/issues/9827


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the 
following questions.
   Don't worry if they're not all applicable; just try to include what you can 
:-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   This questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 1.10.11
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl 
version`): 1.16
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**: Amazon EKS
   - **OS** (e.g. from /etc/os-release):
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**:
   
   **What happened**:
   
   If `resources` argument has partial parameters, KubernetesPodOperator 
generates default as None, but should not have a key.
   
   It is written here:
   
https://github.com/apache/airflow/blob/d23fa2f8896c5e31745131e6917f1970b4aa590f/airflow/kubernetes/pod.py#L82
   
   For example, if I made operator like 
`KubernetesPodOperator(resources={'limit_cpu': '500m'})`, generated pods have 
wrong limits like below:
   
   ```
     24   │ Containers:
     25   │   base:
     26   │     Image:      xxxxxxxx
     27   │     Port:       <none>
     28   │     Host Port:  <none>
     29   │     Limits:
     30   │       cpu:                500m
     31   │       ephemeral-storage:  0
     32   │       memory:             0
     33   │       nvidia.com/gpu:     0
     34   │     Requests:
     35   │       cpu:                0
     36   │       ephemeral-storage:  0
     37   │       memory:             0
     38   │       nvidia.com/gpu:     0
   ...
   ...
    107   │   Normal   Created    20m   kubelet, xxx  Created container base
    108   │   Normal   Started    20m   kubelet, xxx  Started container base
    109   │   Warning  Evicted    20m   kubelet, xxx  Pod ephemeral local 
storage usage exceeds the total limit of containers 0.
    110   │   Normal   Killing    20m   kubelet, xxx  Stopping container base
   ```
   
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**:
   
   Omit None value of limits and requests.
   For example, Resources.to_k8s_client_obj should be modified like that:
   
   ```
       def to_k8s_client_obj(self):
           limits = {}
           if self.limit_cpu:
               limits['cpu'] = self.limit_cpu
           return k8s.V1ResourceRequirements(limits=limits, requests=reqests)
   ```
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   <!---
   
   As minimally and precisely as possible. Keep in mind we do not have access 
to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using 
minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a 
youtube video of the bug in action
   
   You can include images using the .md sytle of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an 
unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to