mik-laj commented on a change in pull request #10282:
URL: https://github.com/apache/airflow/pull/10282#discussion_r468149814
##########
File path: tests/test_local_settings.py
##########
@@ -149,3 +159,14 @@ def test_pod_mutation_hook(self):
settings.pod_mutation_hook(pod)
assert pod.namespace == 'airflow-tests'
+
+ def test_custom_policy(self):
Review comment:
This code doesn't test any DagBag logic, just the settings code (which
is already tested) and the code of the SETTINGS_FILE_CUSTOM_POLICY, but it is
part of tests. So there is no test that verifies the actual changes you have
made.
I would be happy if you would add one test based on ``test_rules.py``.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
