potiuk commented on pull request #10470:
URL: https://github.com/apache/airflow/pull/10470#issuecomment-678762991
I do not like the idea of failing imports, I have no idea whether there are
no side effects and I think those tests woudl fail if the import fails, because
there would be no way to count the queries. I even prefer to move it where it
belongs.
Perf_kit it is essentially one of the test utils we have (currently).
If You intend to make it a standalone tool, you should make it a separate
library on pypi and import it from there. I tink that might be a good idea to
be honest - why don't you do it @mik-laj ?
I think perf-kit is a good candidate to release via PyPi as standalone
tool. I think it would be rather useful for others. I'd really encourage you to
do so.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
