yuqian90 commented on pull request #10153:
URL: https://github.com/apache/airflow/pull/10153#issuecomment-683611508


   Hi, @houqp  and reviewers, here are the latest changes since you last 
reviewed:
   
   - No more prefixing of `task_id` per the discussion 
[here](https://github.com/apache/airflow/pull/10153#discussion_r479914159). The 
user is responsible for maintaining unique `task_id` across the entire DAG, 
just like before.
   - Per the discussion in the email "[AIP-34] Rewrite SubDagOperator" with 
@casassg, if group2 depends on group1, instead of drawing an edge between every 
task in group1 and every task in group2, the two functions 
`task_group_to_dict()` and `dag_edges()` now produce a dummy node for the 
TaskGroup and join all the edges onto that node. This greatly cuts down the 
number of edges and speeds up UI rendering many times. This is a UI-only 
change. Internally, all tasks in group2 still depend on all tasks in group1. 
The dummy nodes only appear on the UI. They don't exist internally.
   
   This is what `example_task_group.py` now looks like. The circles between 
`section_1.1` and `section_1.2` are the dummy nodes I'm talking about. They 
only appear on the graph and not as actual tasks anywhere.
   
   
![image](https://user-images.githubusercontent.com/6637585/91693296-64b1fb00-eb9d-11ea-80dd-02445604aa85.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to