mik-laj commented on a change in pull request #10403:
URL: https://github.com/apache/airflow/pull/10403#discussion_r480066043
##########
File path: airflow/providers/google/cloud/operators/dataproc.py
##########
@@ -157,8 +157,8 @@ class ClusterGenerator:
# pylint: disable=too-many-arguments,too-many-locals
def __init__(
self,
- project_id: Optional[str] = None,
- cluster_name: Optional[str] = None,
+ project_id: str,
+ cluster_name: str,
Review comment:
It depends if this parameter was actually optional before. I think
cluster_name was a required parameter, but we had the wrong method signature.
In that case, this change doesn't change anything, so it's not a breaking
change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
