potiuk commented on a change in pull request #5:
URL: https://github.com/apache/airflow-client-go/pull/5#discussion_r481464286
##########
File path: .github/workflows/ci.yml
##########
@@ -46,8 +46,10 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v1
with:
- go-version: 1.14
+ go-version: 1.15
id: go
- name: build & test
- run: cd airflow && go test
+ run: |
+ go test
+ cd airflow && go test
Review comment:
Just a comment here : even being an old-timer and Bash-afficionado, I'd
strongly discourage Makefiles to any new projects in favour of more modern
tools.
Especially if you do not plan to use Makefile's build dependency management
(which is the powerful part). In most part simple bash script is enough for
simple cases, and in more complex ones https://bazel.build/ seems to be so much
better choice and already pretty standard.
Also, the approach where you have separate commands/scripts in Ci depending
on each other is good enough in most cases IMHO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
