SalAlba commented on a change in pull request #10864:
URL: https://github.com/apache/airflow/pull/10864#discussion_r486953545
##########
File path: .gitignore
##########
@@ -205,3 +205,22 @@ Chart.lock
# Might be generated when you build wheels
pip-wheel-metadata
+
+# tmp ...
Review comment:
Ok, I'm back guess, will the `tmp` mean temporary, but this changes
should be just local on my machine :smile:
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -191,7 +203,7 @@ def get_iam_token(self, conn):
return login, token, port
@staticmethod
- def _generate_insert_sql(table, values, target_fields, replace, **kwargs):
+ def _generate_insert_sql(table: str, values: Tuple[object, ...],
target_fields: Iterable[str], replace: bool, **kwargs) -> str:
Review comment:
@turbaszek I will fix that right now :+1:
##########
File path: .gitignore
##########
@@ -205,3 +205,22 @@ Chart.lock
# Might be generated when you build wheels
pip-wheel-metadata
+
+# tmp ...
Review comment:
Ok, I'm back guys, will the `tmp` mean temporary, but this changes
should be just local on my machine :smile:
##########
File path: .gitignore
##########
@@ -205,3 +205,22 @@ Chart.lock
# Might be generated when you build wheels
pip-wheel-metadata
+
+# tmp ...
+Backups/
+Cache/
+CachedData/
+CachedExtensions/
+Code Cache/
+Cookies
+Cookies-journal
+GPUCache/
+Network Persistent State
+Session Storage/
+TransportSecurity
+User/
+languagepacks.json
+machineid
+rapid_render.json
+storage.json
+tmp.md
Review comment:
This is done
##########
File path: .gitignore
##########
@@ -205,3 +205,22 @@ Chart.lock
# Might be generated when you build wheels
pip-wheel-metadata
+
+# tmp ...
Review comment:
Ok, I'm back guess, will the `tmp` mean temporary, but this changes
should be just local on my machine :smile:
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -191,7 +203,7 @@ def get_iam_token(self, conn):
return login, token, port
@staticmethod
- def _generate_insert_sql(table, values, target_fields, replace, **kwargs):
+ def _generate_insert_sql(table: str, values: Tuple[object, ...],
target_fields: Iterable[str], replace: bool, **kwargs) -> str:
Review comment:
@turbaszek I will fix that right now :+1:
##########
File path: .gitignore
##########
@@ -205,3 +205,22 @@ Chart.lock
# Might be generated when you build wheels
pip-wheel-metadata
+
+# tmp ...
Review comment:
Ok, I'm back guys, will the `tmp` mean temporary, but this changes
should be just local on my machine :smile:
##########
File path: .gitignore
##########
@@ -205,3 +205,22 @@ Chart.lock
# Might be generated when you build wheels
pip-wheel-metadata
+
+# tmp ...
+Backups/
+Cache/
+CachedData/
+CachedExtensions/
+Code Cache/
+Cookies
+Cookies-journal
+GPUCache/
+Network Persistent State
+Session Storage/
+TransportSecurity
+User/
+languagepacks.json
+machineid
+rapid_render.json
+storage.json
+tmp.md
Review comment:
This is done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
