[
https://issues.apache.org/jira/browse/AIRFLOW-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Papanicolaou updated AIRFLOW-75:
-------------------------------------
Description:
The bug is in:
https://github.com/apache/incubator-airflow/blob/3198756bceb9048829cfcd225e50336b6eee8f76/airflow/hooks/S3_hook.py#L55
Comment in _parse_s3_config, lines 43-44:
:param config_format: config type. One of "boto", "s3cmd" or "aws".
Defaults to "boto"
However in S3Hook on lines 111-112:
# The format can be None and will default to boto in the parser
self.s3_config_format = self.extra_params.get('s3_config_format')
So what happens is, if s3_config_format is None, in line 55 it hasn't properly
set it as the default value before applying the lower method.
was:
The bug is in:
https://github.com/apache/incubator-airflow/blob/3198756bceb9048829cfcd225e50336b6eee8f76/airflow/hooks/S3_hook.py#L55
Comment in _parse_s3_config, lines 43-44:
:param config_format: config type. One of "boto", "s3cmd" or "aws".
Defaults to "boto"
However in S3Hook on lines 111-112:
# The format can be None and will default to boto in the parser
self.s3_config_format = self.extra_params.get('s3_config_format')
So what happens is, if s3_config_format is None, in line 55 it hasn't properly
set it as the default value before applying the lower method.
> S3 config file parsing
> ----------------------
>
> Key: AIRFLOW-75
> URL: https://issues.apache.org/jira/browse/AIRFLOW-75
> Project: Apache Airflow
> Issue Type: Bug
> Components: hooks
> Affects Versions: Airflow 1.7.0
> Reporter: Alex Papanicolaou
> Priority: Minor
>
> The bug is in:
> https://github.com/apache/incubator-airflow/blob/3198756bceb9048829cfcd225e50336b6eee8f76/airflow/hooks/S3_hook.py#L55
> Comment in _parse_s3_config, lines 43-44:
> :param config_format: config type. One of "boto", "s3cmd" or "aws".
> Defaults to "boto"
> However in S3Hook on lines 111-112:
> # The format can be None and will default to boto in the parser
> self.s3_config_format = self.extra_params.get('s3_config_format')
> So what happens is, if s3_config_format is None, in line 55 it hasn't
> properly set it as the default value before applying the lower method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
