Repository: incubator-airflow Updated Branches: refs/heads/master ddb554f2c -> 8b9ead747
[AIRFLOW-313] Fix code style for sqoop_hook.py Closes #1651 from skudriashev/airflow-313 Project: http://git-wip-us.apache.org/repos/asf/incubator-airflow/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-airflow/commit/8b9ead74 Tree: http://git-wip-us.apache.org/repos/asf/incubator-airflow/tree/8b9ead74 Diff: http://git-wip-us.apache.org/repos/asf/incubator-airflow/diff/8b9ead74 Branch: refs/heads/master Commit: 8b9ead747bc3eb3d8499d342386f82a769254563 Parents: ddb554f Author: Stanislav Kudriashev <stas.kudrias...@gmail.com> Authored: Wed Jul 6 10:34:23 2016 +0200 Committer: Bolke de Bruin <bo...@xs4all.nl> Committed: Wed Jul 6 10:34:26 2016 +0200 ---------------------------------------------------------------------- airflow/contrib/hooks/sqoop_hook.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-airflow/blob/8b9ead74/airflow/contrib/hooks/sqoop_hook.py ---------------------------------------------------------------------- diff --git a/airflow/contrib/hooks/sqoop_hook.py b/airflow/contrib/hooks/sqoop_hook.py index f213fc4..ef25b7d 100644 --- a/airflow/contrib/hooks/sqoop_hook.py +++ b/airflow/contrib/hooks/sqoop_hook.py @@ -59,7 +59,7 @@ class SqoopHook(BaseHook): def get_conn(self): pass - def Popen(self, cmd, export=False, **kwargs): + def Popen(self, cmd, export=False, **kwargs): # noqa """ Remote Popen @@ -68,13 +68,9 @@ class SqoopHook(BaseHook): :return: handle to subprocess """ prefixed_cmd = self._prepare_command(cmd, export=export) - print prefixed_cmd return subprocess.Popen(prefixed_cmd, **kwargs) def _prepare_command(self, cmd, export=False): - - connection_cmd = "" - if export: connection_cmd = ["sqoop", "export", "--verbose"] else: @@ -96,7 +92,8 @@ class SqoopHook(BaseHook): if self.archives: connection_cmd += ["-archives", self.archives] - connection_cmd += ["--connect", "{}:{}/{}".format(self.conn.host, self.conn.port, self.conn.schema)] + connection_cmd += ["--connect", "{}:{}/{}".format(self.conn.host, self.conn.port, + self.conn.schema)] connection_cmd += cmd return connection_cmd @@ -155,7 +152,8 @@ class SqoopHook(BaseHook): output, stderr = p.communicate() if p.returncode != 0: - # I like this better: RemoteCalledProcessError(p.returncode, cmd, self.host, output=output) + # I like this better: RemoteCalledProcessError(p.returncode, cmd, self.host, + # output=output) raise AirflowException("Cannot execute {} on {}. Error code is: " "{}. Output: {}, Stderr: {}" .format(cmd, self.conn.host, @@ -189,7 +187,8 @@ class SqoopHook(BaseHook): output, stderr = p.communicate() if p.returncode != 0: - # I like this better: RemoteCalledProcessError(p.returncode, cmd, self.host, output=output) + # I like this better: RemoteCalledProcessError(p.returncode, cmd, self.host, + # output=output) raise AirflowException("Cannot execute {} on {}. Error code is: " "{}. Output: {}, Stderr: {}" .format(cmd, self.conn.host, @@ -216,7 +215,8 @@ class SqoopHook(BaseHook): output, stderr = p.communicate() if p.returncode != 0: - # I like this better: RemoteCalledProcessError(p.returncode, cmd, self.host, output=output) + # I like this better: RemoteCalledProcessError(p.returncode, cmd, self.host, + # output=output) raise AirflowException("Cannot execute {} on {}. Error code is: " "{}. Output: {}, Stderr: {}" .format(cmd, self.conn.host,
